On 5/14/20 10:24 AM, Linus Walleij wrote:
On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@xxxxxxxxx> wrote:
From: dillon min <dillon.minfei@xxxxxxxxx>
Enable the ltdc & ili9341 on stm32429-disco board.
Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx>
This mostly looks good but...
+&spi5 {
+ status = "okay";
+ pinctrl-0 = <&spi5_pins>;
+ pinctrl-names = "default";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>;
+ dmas = <&dma2 3 2 0x400 0x0>,
+ <&dma2 4 2 0x400 0x0>;
+ dma-names = "rx", "tx";
These DMA assignments seem to be SoC things and should
rather be in the DTS(I) file where &spi5 is defined, right?
stm32f429.dtsi I suppose?
I agree with Linus, DMA have to be defined in SoC dtsi. And if a board
doesn't want to use it, we use the "delete-property".
It is likely the same no matter which device is using spi5.
Yours,
Linus Walleij
