Hi Matthias,
The loop should have curly braces ("use braces when a loop contains more than
a single simple statement"), even though the compiler doesn't need them in
this case. This is not a loop, but I was told by a maintainer that it equally
applies, which makes sense.
You could avoid one level of indentation through:
if (!console_drivers)
goto exit;
+ for_each_console(bcon)
Actually the NULL check of 'console_drivers' is not needed:
#define for_each_console(con) \
for (con = console_drivers; con != NULL; con = con->next)
Ok, I will remove this check.
Regards,
Akash
see also:
commit caa72c3bc584bc28b557bcf1a47532a7a6f37e6f
Author: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon Feb 3 15:31:25 2020 +0200
console: Drop double check for console_drivers being non-NULL
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
