On Sat, May 02, 2020 at 01:47:47PM +0200, Martin Blumenstingl wrote:
> Now that we have the DT validation in place, let's convert the device
> tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2
> PHY over to a YAML schema.
>
> While here, also add the fallback compatible string
> "amlogic,meson-gxbb-usb2-phy" which is already used in
> arch/arm/boot/dts/meson{,8,8b}.dtsi.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> ---
> .../phy/amlogic,meson8b-usb2-phy.yaml | 61 +++++++++++++++++++
> .../bindings/phy/meson8b-usb2-phy.txt | 28 ---------
> 2 files changed, 61 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml
> delete mode 100644 Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml
> new file mode 100644
> index 000000000000..c2fe8c08d99e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY
> +
> +maintainers:
> + - Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - amlogic,meson8-usb2-phy
> + - amlogic,meson8b-usb2-phy
Needs 2 more spaces indent.
> + - const: amlogic,meson-mx-usb2-phy
> + - const: amlogic,meson-gxbb-usb2-phy
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + minItems: 2
> +
> + clock-names:
> + items:
> + - const: usb_general
> + - const: usb
> +
> + resets:
> + minItems: 1
> +
> + "#phy-cells":
> + const: 0
> +
> + phy-supply:
> + description:
Wrong indentation.
> + Phandle to a regulator that provides power to the PHY. This
> + regulator will be managed during the PHY power on/off sequence.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - "#phy-cells"
Add:
additionalProperties: false
> +
> +examples:
> + - |
> + usb-phy@c0000000 {
> + compatible = "amlogic,meson-gxbb-usb2-phy";
> + reg = <0xc0000000 0x20>;
> + resets = <&reset_usb_phy>;
> + clocks = <&clk_usb_general>, <&reset_usb>;
> + clock-names = "usb_general", "usb";
> + phy-supply = <&usb_vbus>;
> + #phy-cells = <0>;
> + };
