2014-05-21 14:55 GMT-07:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>: > On 05/22/2014 01:38 AM, Florian Fainelli wrote: > >> of_phy_connect_fixed_link() is becoming obsolete, and also required >> platform code to register the fixed PHYs at the specified addresses for >> those to be usable. Get rid of it and use the new of_phy_is_fixed_link() >> plus of_phy_register_fixed_link() helpers to transition over the new >> scheme. > > >> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> >> --- >> drivers/net/ethernet/broadcom/bcmsysport.c | 17 +++++++++++++++-- >> drivers/net/ethernet/broadcom/bcmsysport.h | 1 + >> 2 files changed, 16 insertions(+), 2 deletions(-) > > >> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c >> b/drivers/net/ethernet/broadcom/bcmsysport.c >> index d40c5b969e9e..dc708a888f80 100644 >> --- a/drivers/net/ethernet/broadcom/bcmsysport.c >> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c >> @@ -1327,8 +1327,8 @@ static int bcm_sysport_open(struct net_device *dev) >> /* Read CRC forward */ >> priv->crc_fwd = !!(umac_readl(priv, UMAC_CMD) & CMD_CRC_FWD); >> >> - priv->phydev = of_phy_connect_fixed_link(dev, >> bcm_sysport_adj_link, >> - >> priv->phy_interface); >> + priv->phydev = of_phy_connect(dev, priv->phy_dn, >> bcm_sysport_adj_link, >> + 0, priv->phy_interface); > > > The continuation line should start on the next character after ( on the > above line, according to the networking coding style. Unless I am once again not following the coding style, the patch in patchwork has this correctly, and so does my file locally: http://patchwork.ozlabs.org/patch/351323/ -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
