On Tue, 12 May 2020 at 02:26, Sakari Ailus <sakari.ailus@xxxxxx> wrote: > > Hi Robert, > > On Mon, May 11, 2020 at 01:03:49PM +0200, Robert Foss wrote: > > Add match table, enable ov8856_probe() to support > > both ACPI and DT modes. > > > > ACPI and DT modes are primarily distinguished from > > by checking for ACPI mode and by having resource like > > be NULL. > > > > Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx> > > Applied with this small diff --- please check with checkpatch.pl on the > next time. Thanks! Thanks Sakari, I appreciate it! > > diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c > index 1657e03d9a9d..4ca27675cc5a 100644 > --- a/drivers/media/i2c/ov8856.c > +++ b/drivers/media/i2c/ov8856.c > @@ -1226,8 +1226,7 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev) > if (!fwnode) > return -ENXIO; > > - ret = fwnode_property_read_u32(fwnode, "clock-frequency", > - &xvclk_rate); > + ret = fwnode_property_read_u32(fwnode, "clock-frequency", &xvclk_rate); > if (ret) > return ret; > > @@ -1244,10 +1243,11 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev) > } > > if (xvclk_rate != OV8856_XVCLK_19_2) > - dev_warn(dev, "external clock rate %d is unsupported", xvclk_rate); > + dev_warn(dev, "external clock rate %u is unsupported", > + xvclk_rate); > > ov8856->reset_gpio = devm_gpiod_get_optional(dev, "reset", > - GPIOD_OUT_LOW); > + GPIOD_OUT_LOW); > if (IS_ERR(ov8856->reset_gpio)) > return PTR_ERR(ov8856->reset_gpio); > > -- > Kind regards, > > Sakari Ailus
