Re: [PATCH v2] ARM: dts: zynq: Fix ethernet PHY for v5 schematics

[Michal Simek <michal.simek@xxxxxxxxxx>]

Hi,

On 01. 05. 20 18:10, Matwey V. Kornilov wrote:
> Hi Anton,
> 
> I hope you are doing good. Could you please check this patch, since
> you are initial author of zynq-zturn.dts and I suppose you do have the
> "v4" board variant to test.
> 
> вт, 28 апр. 2020 г. в 13:04, Matwey V. Kornilov <matwey@xxxxxxxxxx>:
>>
>> There are at least two different versions existing for MYIR Zturn:
>>
>>  * v4 schematics has Atheros AR8035 PHY at 0b000
>>      http://www.myirtech.com/download/Zynq7000/Z-TURNBOARD_schematic.pdf
>>  * v5 schematics has Micrel KSZ9031 PHY at 0b011
>>      v5 schematics available at DVD disk supplied with the board
>>
>> Specify both PHYs to make ethernet interface working for any board
>> revision. This commit relies on of_mdiobus_register() behavior.
>> When phy-handle is missed, every nested PHY node is considered,
>> while ENODEVs are ignored.
>>
>> Before the patch:
>>
>> [   28.295002] macb e000b000.ethernet eth0: Could not attach PHY (-19)
>>
>> After the patch:
>>
>> [   28.257365] macb e000b000.ethernet eth0: PHY [e000b000.ethernet-ffffffff:00] driver [Micrel KSZ9031 Gigabit PHY] (irq=POLL)
>> [   28.257384] macb e000b000.ethernet eth0: configuring for phy/rgmii-id link mode
>>
>> Signed-off-by: Matwey V. Kornilov <matwey@xxxxxxxxxx>
> 
> Cc: Anton Gerasimov <tossel@xxxxxxxxx>
> 
>> ---
>> Changes since v1:
>>  - reworded commit message
>>
>>  arch/arm/boot/dts/zynq-zturn.dts | 13 ++++++++++---
>>  1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
>> index 5ec616ebca08..07da9cf60d02 100644
>> --- a/arch/arm/boot/dts/zynq-zturn.dts
>> +++ b/arch/arm/boot/dts/zynq-zturn.dts
>> @@ -67,10 +67,17 @@
>>  &gem0 {
>>         status = "okay";
>>         phy-mode = "rgmii-id";
>> -       phy-handle = <&ethernet_phy>;
>>
>> -       ethernet_phy: ethernet-phy@0 {
>> -               reg = <0x0>;
>> +       ethernet-phy@0 {
>> +               compatible = "ethernet-phy-ieee802.3-c22";
>> +               reg = <0>;
>> +               max-speed = <1000>;
>> +       };
>> +
>> +       ethernet-phy@3 {
>> +               compatible = "ethernet-phy-ieee802.3-c22";
>> +               reg = <3>;
>> +               max-speed = <1000>;
>>         };
>>  };
>>
>> --
>> 2.16.4
>>
> 
> 

Anton: Waiting for your testing.

Thanks,
Michal