On Fri, May 08, 2020 at 07:34:05PM +0800, Jiaxun Yang wrote: > We can now enable generic PCI driver in Kconfig, and remove legacy > PCI driver code. > > Radeon vbios quirk is moved to the platform folder to fit the > new structure. > diff --git a/arch/mips/loongson64/vbios_quirk.c b/arch/mips/loongson64/vbios_quirk.c > new file mode 100644 > index 000000000000..1f0a462aeddd > --- /dev/null > +++ b/arch/mips/loongson64/vbios_quirk.c > @@ -0,0 +1,29 @@ > +// SPDX-License-Identifier: GPL-2.0 In arch/mips/pci/fixup-loongson3.c, pci_fixup_radeon() was under "GPL version 2 or (at your option) any later version." Documentation/process/license-rules.rst says that corresponds to GPL-2.0+, not GPL-2.0. > +static void pci_fixup_radeon(struct pci_dev *pdev) > +{ > ... > +} > diff --git a/arch/mips/pci/fixup-loongson3.c b/arch/mips/pci/fixup-loongson3.c > deleted file mode 100644 > index 8a741c2c6685..000000000000 > --- a/arch/mips/pci/fixup-loongson3.c > +++ /dev/null > @@ -1,71 +0,0 @@ > -/* > - * fixup-loongson3.c > - * > - * Copyright (C) 2012 Lemote, Inc. > - * Author: Xiang Yu, xiangy@xxxxxxxxxx > - * Chen Huacai, chenhc@xxxxxxxxxx > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License as published by the > - * Free Software Foundation; either version 2 of the License, or (at your > - * option) any later version. > - * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED > - * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN > - * NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, > - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > - * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > - * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON > - * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > - * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > - * > - */ > - > -#include <linux/pci.h> > -#include <boot_param.h> > - > -static void print_fixup_info(const struct pci_dev *pdev) > -{ > - dev_info(&pdev->dev, "Device %x:%x, irq %d\n", > - pdev->vendor, pdev->device, pdev->irq); > -} > - > -int pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) > -{ > - print_fixup_info(dev); > - return dev->irq; > -} > - > -static void pci_fixup_radeon(struct pci_dev *pdev) > -{ > - struct resource *res = &pdev->resource[PCI_ROM_RESOURCE]; > - > - if (res->start) > - return; > - > - if (!loongson_sysconf.vgabios_addr) > - return; > - > - pci_disable_rom(pdev); > - if (res->parent) > - release_resource(res); > - > - res->start = virt_to_phys((void *) loongson_sysconf.vgabios_addr); > - res->end = res->start + 256*1024 - 1; > - res->flags = IORESOURCE_MEM | IORESOURCE_ROM_SHADOW | > - IORESOURCE_PCI_FIXED; > - > - dev_info(&pdev->dev, "BAR %d: assigned %pR for Radeon ROM\n", > - PCI_ROM_RESOURCE, res); > -} > - > -DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID, > - PCI_CLASS_DISPLAY_VGA, 8, pci_fixup_radeon); > - > -/* Do platform specific device initialization at pci_enable_device() time */ > -int pcibios_plat_dev_init(struct pci_dev *dev) > -{ > - return 0; > -}