Re: [PATCH 2/2] Input: add driver for power button on Dell Wyse 3020

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> +struct ec_input_response {
> +	u8 reserved;
> +	u8 msg_counter:2;
> +	u8 count:2;
> +	u8 type:4;
> +	u8 data[3];
> +} __packed;

Bitfields, and relying on them being in the right place for communication with hardware.

We don't usually do that, and there may be reasons why we don't. I'm pretty sure it 
breaks on big endian... and Im not sure if there's something else.

										Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux