Re: [PATCH v2 14/20] mips: Use offset-sized IO-mem accessors in CPS debug printout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Wed, May 06, 2020 at 09:16:24PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 05/06/2020 08:42 PM, Sergey.Semin@xxxxxxxxxxxxxxxxxxxx wrote:
> 
> > From: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> > 
> > Similar to commit 8e5c62e38a88 ("mips: early_printk_8250: Use offset-sized
> > IO-mem accessors") the IO-memory might require to use a proper load/store
> > instructions (like Bailal-T1 IO-memory). To fix the cps-vec UART debug
> 
>    Baikal? :-)

Yeah, thanks.)

> 
> > printout lets use the memory access instructions in accordance with the
> > UART registers offset config specified at boot time.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> > Cc: Paul Burton <paulburton@xxxxxxxxxx>
> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: linux-pm@xxxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > 
> > ---
> > There might be another problem in cps-vec-ns16550.S connected with the
> > difference in CPU/devices endinanness on some platforms. But there is
> 
>    Endianness.

Ah, this won't get into the commit message anyway. But thanks for noticing.)

-Sergey


> 
> > no such for Baikal-T1 SoC.
> [...]
> 
> MBR, Sergei



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux