On Wed, May 6, 2020 at 9:04 AM Andrew F. Davis <afd@xxxxxx> wrote: > On 5/4/20 4:50 AM, Brian Starkey wrote: > > On Fri, May 01, 2020 at 11:40:16AM -0700, John Stultz wrote: > >> So the name we expose is the CMA name itself. So with dt it will be > >> the name of the reserved memory node that the flag property is added > >> to. > >> > > > > Yeah I'm just wondering if that's "stable" so we can say "the heap > > will use the node name", or if saying that would cause us a headache > > in the future. > > > The issue is going to be this causes the node name in DT to become a > kind of ABI. Right now until we have some userspace lib that enumerates > the heaps in a stable way programs will hard-code the full heap name, > which right now would look like: > > char *heap = "/dev/dma_heap/dma_heap_mem@89000000"; > If that's what the device chose to export. > Yuk.. we might want to look into exporting heap properties to make them > searchable based on something other than name here soon. Or this will be > a mess to cleanup in the future. Eh. I don't see this as such an issue. On different systems we have different device nodes. Some boards have more or fewer NICs, or various partitions, etc. There has to be some device specific userland config that determines which partitions are mounted where (this is my "gralloc is fstab" thesis :) I think with the heaps, qualities other than name are going to be poorly specified or unenumerable, so any generic query interface is going to fall down there (and be awful to use). thanks -john
