Re: [RFT PATCH 5/5] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for reviewing the patches. Some comments below,

On mié 06-05-2020 09:44:19, Geert Uytterhoeven wrote: 
> Can't you avoid the need for patches
> [RFT PATCH 1/5] arm64: dts: draak: Reorder hdmi-encoder@39 reg and
> reg-names properties
> [RFT PATCH 2/5] ARM: dts: wheat: reorder reg and reg-names properties
> in hdmi bridges
> 
> by using
> 
>     items:
>       enum:
>         - main
>         - edid
>         - cec
>         - packet
> 
> instead?

Not really, because that defines a scalar property that can take any of
those values (if I'm not mistaken), and the core schema enforces that
reg-names must be an array.

I think the closest I can get to what you mean would be something like
this:

    items:
      - enum:
        - main
        - edid
        - cec
        - packet
      - enum:
        - main
        - edid
        - cec
        - packet
      - enum:
        - main
        - edid
        - cec
        - packet
      - enum:
        - main
        - edid
        - cec
        - packet

But then that wouldn't prevent anyone from defining duplicate reg-names
(eg. "main", "cec", edid", "cec"), which is even worse IMO.

Cheers,
Ricardo



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux