> > -static void pstore_register_kmsg(void) > > +static void pstore_register_kmsg(int dmesg_all) > > { > > + if (dmesg_all) > > + pstore_dumper.max_reason = KMSG_DUMP_MAX; > > So, I'd like to avoid any new arguments in the API and instead add a new > field to struct pstore_info, which will be valid when PSTORE_FLAGS_DMESG > is set, and the max kdump reason can be set there by the pstore backends. Hi Kees, I am trying to verify that I understand the request correctly: 1. pstore_register_kmsg() -> remove argument. 2. pstore_info -> add a new field max_kmsg_reason: contains the actual reason value 3. Modify: pstore_register() to set this field in pstore_dumper prior to calling pstore_register_kmsg(). 4. remove ramoops.dump_all boolean parameter 5. add a new parameter ramoops.max_reason integer variable, which will be set in pstore_register_kmsg 6. Modify other users of pstore_register() to provide the correct max_kmsg_reason. Is this correct? Thank you, Pasha