On Mon, Apr 27, 2020 at 10:36:14AM +0000, Charles Keepax wrote: > On Mon, Apr 27, 2020 at 11:28:12AM +0100, Charles Keepax wrote: > > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > > --- > > + lochnagar-pinctrl { > > + compatible = "cirrus,lochnagar-pinctrl"; > > + > > + gpio-controller; > > + #gpio-cells = <2>; > > + gpio-ranges = <&lochnagar 0 0 LOCHNAGAR2_PIN_NUM_GPIOS>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinsettings>; > > This seems to cause the following error: > > Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml: > lochnagar@22: lochnagar-pinctrl:pin-settings:phandle: [[4]] is not of type 'object' > > I think the schema is correct and the problem is one of tooling, > I have been poking at it for a while but can't seem to find a way > to silence this one. Any advice would be greatly appreciated. The problem is the "^.*$" patterns to match child node names also match properties like 'phandle'. Ideally, you'd have some pattern to match on for the node names. There is work-around doing: "^.*$": if: type: object then: properties: ... But I much prefer to see node names updated. '-pins$' is a common pattern. Rob