On Fri, May 1, 2020 at 3:48 AM Brian Starkey <brian.starkey@xxxxxxx> wrote:
> On Fri, May 01, 2020 at 07:39:47AM +0000, John Stultz wrote:
> > +bool cma_dma_heap_enabled(struct cma *cma)
> > +{
> > + return !!cma->dma_heap;
>
> Stylistic thing, but I don't think the !! is really necessary. It's
> already a bool anyway.
Yea, I was using a bit field earlier and then moved to a bool for
simplicity and left this. I saw it as soon as I sent the patch, so
it's already fixed up.
> > @@ -157,6 +167,7 @@ static int __init cma_init_reserved_areas(void)
> > }
> > core_initcall(cma_init_reserved_areas);
> >
> > +
>
> nit: spurious newline
Yep. Same. The things you only see once the mail is sent. :)
Thanks so much for the review though!
-john
