Re: [PATCH] dt-bindings: power: Convert power_supply text to yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sebastian

On 5/1/20 11:58 AM, Sebastian Reichel wrote:
Hi,

On Thu, Apr 30, 2020 at 10:18:41AM -0500, Dan Murphy wrote:
Convert the power_supply.txt to power-supply.yaml.
This conversion entailed fixing up the binding to being yaml and dt
checker compliant.
Looks mostly good to me, thanks for taking care of it.

Added a note in the power_supply.txt to reference the power-supply.yaml
Yes, we should keep the file until all bindings referencing the file
have been converted to YAML.
Ack
CC: Rob Herring <robh@xxxxxxxxxx>
Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
---
  .../bindings/power/supply/power-supply.yaml   | 40 +++++++++++++++++++
  .../bindings/power/supply/power_supply.txt    | 25 +-----------
  2 files changed, 42 insertions(+), 23 deletions(-)
  create mode 100644 Documentation/devicetree/bindings/power/supply/power-supply.yaml

diff --git a/Documentation/devicetree/bindings/power/supply/power-supply.yaml b/Documentation/devicetree/bindings/power/supply/power-supply.yaml
new file mode 100644
index 000000000000..cfbc79833ed8
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/power-supply.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/supply/power_supply.yaml#";
This should be power-supply instead of power_supply, which is also
reported by dtb_binding_check on my system :)

Yeah I had an untracked file called power_supply.yaml and removed it after checking it in.

I will change this


+$schema: "http://devicetree.org/meta-schemas/core.yaml#";
+
+title: Power Supply Core Support
+
+maintainers:
+  - Sebastian Reichel <sre@xxxxxxxxxx>
+
+properties:
+  power-supplies:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description:
+      This property is added to a supply in order to list the devices which
+      supply it power, referenced by their phandles.
+
+examples:
+  - |
+    power {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      usb_charger:power@e {
+        compatible = "some,usb-charger";
+        reg = <0xe>;
+      };
+
+      ac_charger:power@c {
^^^ while at it, let's also fix this up and use
charger instead of power (for both entries).

Ack

Dan



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux