On Thu, 2020-04-30 at 18:13 -0700, Guru Das Srinagesh wrote: > On Wed, Apr 29, 2020 at 08:50:10AM +0100, Lee Jones wrote: > > On Tue, 28 Apr 2020, Guru Das Srinagesh wrote: > > > The Qualcomm Technologies, Inc. I2C PMIC Controller is used by > > > multi-function PMIC devices which communicate over the I2C bus. The > > > controller enumerates all child nodes as platform devices, and > > > instantiates a regmap interface for them to communicate over the I2C > > > bus. [] > > > diff --git a/drivers/mfd/qcom-i2c-pmic.c b/drivers/mfd/qcom-i2c-pmic.c [] > > Please don't role your own debug helpers. > > > > The ones the kernel provides are suitably proficient. > > Sure. Would this be acceptable instead, with the custom string replaced by a > macro that the kernel provides? > > #define pr_fmt(fmt) "%s: %s: " fmt, KBUILD_MODNAME, __func__ trivia: It's almost always smaller object code to use the KBUILD_MODNAME as a fixed string instead of as a printf argument. #define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__
