On Thu, Apr 30, 2020 at 1:39 PM saravanan sekar <sravanhome@xxxxxxxxx> wrote: > On 27/04/20 11:30 am, saravanan sekar wrote: > > On 27/04/20 10:51 am, Lee Jones wrote: > >> On Fri, 24 Apr 2020, saravanan sekar wrote: > >>> On 24/04/20 12:53 pm, Lee Jones wrote: > >>>> On Fri, 24 Apr 2020, saravanan sekar wrote: > >>>>> On 24/04/20 11:37 am, Lee Jones wrote: > >>>>>> On Fri, 24 Apr 2020, saravanan sekar wrote: ... > >>>>>> Then how about using 'simple-mfd' and 'syscon'? > >>>>>> > >>>>>> Then you can omit this driver completely. > >>>>> The exception is to support for non device tree platform as well, > >>>>> but I have > >>>>> tested only for ARM device tree platform. > >>>> Is that a reality though? > >>>> > >>>> How else do you see this realistically being registered? > >>>> > >>> I understand that acpi related device table are not covered here, > >>> well I > >>> don't have to platform to test so. > >>> If you ask me to cover acpi related table, I can do but hard to test. > >> I don't know of any reasons why syscon can't be used by ACPI. > >> > >> Please try to solve this issue using 'simple-mfd' and 'syscon'. > > Well the simple-mfd and syscon topic recommended by you when Device > > tree alone is used. > > I wounder still I receive review/improvements comments for this mfd > > patch and also another > > to omit this driver using simple-mfd (rework the series). > > Confused, not sure which is valid and will be accepted at the end. > > I had look into syscon, as far my understanding syscon is supported only > for memory mapped IO. MP2629 > device is over I2C bus, could you share your thought about syscon for > this device? My understanding too, but I didn't dug into it. Something like general regmap support is missing (or I am missing the way how to pass it to syscon). -- With Best Regards, Andy Shevchenko