On 2020-04-29 05:37, Jarkko Sakkinen wrote: > On Mon, Apr 27, 2020 at 03:49:27PM +0300, amirmizi6@xxxxxxxxx wrote: >> From: Amir Mizinski <amirmizi6@xxxxxxxxx> >> >> Using this function while reading/writing data resulted in an aborted >> operation. >> After investigating the issue according to the TCG TPM Profile (PTP) >> Specifications, I found that "request to cancel" should occur only if >> TPM_STS.commandReady bit is lit. >> Note that i couldn't find a case where the present condition >> (in the linux kernel) is valid, so I'm removing the case for >> "TPM_VID_WINBOND" since we have no need for it. >> >> Also, the default comparison is wrong. Only cmdReady bit needs to be >> compared instead of the full lower status register byte. >> >> Fixes: 1f86605 (tpm: Fix cancellation of TPM commands (polling mode)) > > Needs to have exactly 12 hex digits of the hash. > Ok, i'll fix this for version 8. Thank you. > /Jarkko
