Hello Rob, Thanks for the review. On Fri, 2020-04-10 at 12:25 -0500, Rob Herring wrote: > On Mon, Mar 30, 2020 at 08:36:33PM +0800, Dongchun Zhu wrote: > > This patch is to add the Devicetreee binding documentation and > > MAINTAINERS entry for dw9768 actuator. > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > --- > > .../bindings/media/i2c/dongwoon,dw9768.yaml | 62 ++++++++++++++++++++++ > > MAINTAINERS | 7 +++ > > 2 files changed, 69 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml > > new file mode 100644 > > index 0000000..8a353dc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright (c) 2020 MediaTek Inc. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9768.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Dongwoon Anatech DW9768 Voice Coil Motor (VCM) Device Tree Bindings > > + > > +maintainers: > > + - Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > + > > +description: |- > > + The Dongwoon DW9768 is a single 10-bit digital-to-analog (DAC) converter > > + with 100 mA output current sink capability. VCM current is controlled with > > + a linear mode driver. The DAC is controlled via a 2-wire (I2C-compatible) > > + serial interface that operates at clock rates up to 1MHz. This chip > > + integrates Advanced Actuator Control (AAC) technology and is intended for > > + driving voice coil lenses in camera modules. > > + > > +properties: > > + compatible: > > + const: dongwoon,dw9768 > > + > > + reg: > > + maxItems: 1 > > + > > + vin-supply: > > + description: > > + Definition of the regulator used as I2C I/O interface power supply. > > + maxItems: 1 > > You can drop this. *-supply is always a single entry. > Fixed in next release. > > + > > + vdd-supply: > > + description: > > + Definition of the regulator used as VCM chip power supply. > > + maxItems: 1 > > Same here. > Fixed in next release. > > + > > +required: > > + - compatible > > + - reg > > + - vin-supply > > + - vdd-supply > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c2: i2c@11009000 { > > i2c { > Fixed in next release. > > + clock-frequency = <400000>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + dw9768: camera-lens@c { > > + compatible = "dongwoon,dw9768"; > > + reg = <0x0c>; > > + > > + vin-supply = <&mt6358_vcamio_reg>; > > + vdd-supply = <&mt6358_vcama2_reg>; > > + }; > > + }; > > + > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 38fe2f3..5e124d2 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -5134,6 +5134,13 @@ S: Maintained > > F: drivers/media/i2c/dw9714.c > > F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt > > > > +DONGWOON DW9768 LENS VOICE COIL DRIVER > > +M: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > +L: linux-media@xxxxxxxxxxxxxxx > > +S: Maintained > > +T: git git://linuxtv.org/media_tree.git > > +F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml > > + > > DONGWOON DW9807 LENS VOICE COIL DRIVER > > M: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > L: linux-media@xxxxxxxxxxxxxxx > > -- > > 2.9.2
