On Fri, 17 Apr 2020 09:05:24 +0200, Michael Tretter wrote: > The xlnx,vcu binding comprises two adjacent register banks: > > The first register bank ("vcu_slcr") contains registers for setting the > clocks of the vcu and controlling the performance monitors. The second > bank ("logicoreip") contains the configuration settings of the video codec > unit, which are set before synthesizing the bitstream. > > Drivers that drive the actual video codec unit need to to read the > registers from the logicoreip register bank for configuring the vcu > firmware. > > As logicoreip is a too generic name for this register bank, use > "vcu-settings" as a binding name, because the register bank basically > provides the configuration settings of the VCU. > > Therefore, add the vcu-settings binding to provide a syscon interface > for other drivers to read these registers. > > The alternative would have been to merge the two register banks of the > xlnx,vcu binding into one register bank and make xlnx,vcu provide a > syscon interface, but that would lead to more incompatibility than > making second register bank of xlnx,vcu optional. > > Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx> > --- > Changelog: > > v2 -> v3: > - none > > v1 -> v2: > - drop custom select for syscon > --- > .../soc/xilinx/xlnx,vcu-settings.yaml | 34 +++++++++++++++++++ > .../bindings/soc/xilinx/xlnx,vcu.txt | 9 ++--- > 2 files changed, 36 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>