@Rob, thank you for the review. @David, should I send fixes or reworked initial patches? On Tue, Apr 28, 2020 at 12:30:06PM -0500, Rob Herring wrote: > On Fri, Mar 13, 2020 at 12:23 AM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote: > > > > Document the NXP TJA11xx PHY bindings. > > Given the discussion, I'd marked this one as "changes requested" > expecting a new version to review the schema. And gmail decided to > make a new thread due to the extra 'RE:'. So it fell off my radar. > > This schema is fundamentally broken as there's no way to match for > when to apply this schema. How do we find a NXP TJA11xx PHY? I suppose > we can look for 'ethernet-phy' with a child node 'ethernet-phy', but > then that would apply to any phy like this one. This needs a > compatible string IMO given it is non-standard. > > > > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/net/nxp,tja11xx.yaml | 61 +++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/nxp,tja11xx.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml > > new file mode 100644 > > index 000000000000..42be0255512b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: GPL-2.0+ > > Dual license new bindings: > > (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP TJA11xx PHY > > + > > +maintainers: > > + - Andrew Lunn <andrew@xxxxxxx> > > + - Florian Fainelli <f.fainelli@xxxxxxxxx> > > + - Heiner Kallweit <hkallweit1@xxxxxxxxx> > > + > > +description: > > + Bindings for NXP TJA11xx automotive PHYs > > Perhaps some information about how this phy is special. > > > + > > +allOf: > > + - $ref: ethernet-phy.yaml# > > Not needed here as ethernet-phy.yaml already has a 'select' condition to apply. > > > + > > +patternProperties: > > + "^ethernet-phy@[0-9a-f]+$": > > + type: object > > + description: | > > + Some packages have multiple PHYs. Secondary PHY should be defines as > > + subnode of the first (parent) PHY. > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 31 > > + description: > > + The ID number for the child PHY. Should be +1 of parent PHY. > > + > > + required: > > + - reg > > + > > +examples: > > + - | > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + tja1101_phy0: ethernet-phy@4 { > > + reg = <0x4>; > > + }; > > + }; > > + - | > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + tja1102_phy0: ethernet-phy@4 { > > + reg = <0x4>; > > > + #address-cells = <1>; > > + #size-cells = <0>; > > These aren't documented. > > > + > > + tja1102_phy1: ethernet-phy@5 { > > + reg = <0x5>; > > + }; > > + }; > > + }; > > -- > > 2.25.1 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
