On Sun, Apr 26, 2020 at 11:36:01AM -0700, Jonathan Bakker wrote: > On aries boards, the ADC is used for things such as jack detection > and battery temperature monitoring. It is connected to ldo4 of max8998, > so only enable that regulator when we are actually using the ADC. > > Signed-off-by: Jonathan Bakker <xc-racer2@xxxxxxx> > --- > arch/arm/boot/dts/s5pv210-aries.dtsi | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi > index f30bdcb9c083..a103ddb0d720 100644 > --- a/arch/arm/boot/dts/s5pv210-aries.dtsi > +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi > @@ -193,11 +193,6 @@ > regulator-name = "VADC_3.3V"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > - regulator-always-on; > - > - regulator-state-mem { > - regulator-off-in-suspend; > - }; I would expect to keep it disabled during suspend. Why you had to remove this part? Best regards, Krzysztof