Hello, Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Thu, 16 Apr 2020 21:45:13 +0200: > On Wed, 15 Apr 2020 17:57:32 +0200 > Christophe Kerello <christophe.kerello@xxxxxx> wrote: > > > This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros. > > Oh, nice. I didn't know about these macros. This could have saved me > from defining a whole bunch of setters/getters in driver code... > > Love these too! I will definitely use them in the future. Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> Thanks, Miquèl