On 27/04/2020 13:51, Tomi Valkeinen wrote: > On 27/04/2020 13:37, Jyri Sarha wrote: >> On 27/04/2020 13:09, Tero Kristo wrote: >>>> + status = "disabled"; >>> >>> Again, why disabled by default? >>> >> >> tidss device is not functional without a defined video-port. The driver >> is not implemented in a way that it would handle a broken configuration >> gracefully. > > Then we need to fix it. The driver should handle the case where there > are no ports defined just fine. > Just by reading the code, I would say that currently the probe would fail with returned -ENOMEM after calling drm_vblank_init() with zero CRTCs. So should the probe fail gracefully and silently, or should we try to register a DRM device with no CRTCs? Is that even possible? BR, Jyri -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
