On Thu, Mar 19, 2020 at 5:32 AM Kishon Vijay Abraham I <kishon@xxxxxx> wrote: > > Hi Rob, > > On 11/03/20 2:39 am, Rob Herring wrote: > > On Tue, Mar 03, 2020 at 12:17:19PM +0200, Roger Quadros wrote: > >> From: Kishon Vijay Abraham I <kishon@xxxxxx> > >> > >> Add serdes_ln_ctrl node used for selecting SERDES lane mux. > >> > >> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > >> Signed-off-by: Sekhar Nori <nsekhar@xxxxxx> > >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> > >> --- > >> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 27 ++++++++++++ > >> include/dt-bindings/mux/mux-j721e-wiz.h | 53 +++++++++++++++++++++++ > >> 2 files changed, 80 insertions(+) > >> create mode 100644 include/dt-bindings/mux/mux-j721e-wiz.h > >> > >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >> index cbaadee5bfdc..c5d54af37e91 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >> @@ -5,6 +5,8 @@ > >> * Copyright (C) 2016-2019 Texas Instruments Incorporated - http://www.ti.com/ > >> */ > >> #include <dt-bindings/phy/phy.h> > >> +#include <dt-bindings/mux/mux.h> > >> +#include <dt-bindings/mux/mux-j721e-wiz.h> > >> > >> &cbass_main { > >> msmc_ram: sram@70000000 { > >> @@ -19,6 +21,31 @@ > >> }; > >> }; > >> > >> + scm_conf: scm-conf@100000 { > >> + compatible = "syscon", "simple-mfd", "ti,j721e-system-controller"; > > > > Wrong ordering. Most significant first. > > > >> + reg = <0 0x00100000 0 0x1c000>; > >> + #address-cells = <1>; > >> + #size-cells = <1>; > >> + ranges = <0x0 0x0 0x00100000 0x1c000>; > >> + > >> + serdes_ln_ctrl: serdes-ln-ctrl@4080 { > > > > Your syscon.yaml change is not valid if you have child nodes. Do a > > specific binding for this block. > > Do you mean in addition to having platform specific binding for > scm-conf, I need to have platform specific binding for serdes-ln-ctrl. I mean 'dt-bindings: syscon: Add TI's J721E specific compatible string'. While not currently enforced because 'unevaluatedProperties: false' doesn't yet do anything, the intent with syscon.yaml is child nodes are not allowed. If you have child nodes, you need your own schema. Rob
