On Tue, Mar 31, 2020 at 8:31 PM Tanmay Shah <tanmay@xxxxxxxxxxxxxx> wrote: > > These patches add support for Display-Port driver on SnapDragon 845 hardware. It adds > DP driver and DP PLL driver files along with the needed device-tree bindings. > I focused on patches 2, 3 & 5, seems like you have good feedback on the others by more qualified folks than me. At a high level I don't have any major issues with the set. There are some rough edges that I noticed as I was reading it (as would any patch of this size), but I think it's probably not a good use of either of our time for me to nitpick 10k lines of code over multiple iterations. So in the interest of not letting the perfect get in the way of the good, I suggest we apply the set and fix up as time and necessity allow. Patches 2/3/5 are: Acked-by: Sean Paul <seanpaul@xxxxxxxxxxxx> Sean > The block diagram of DP driver is shown below: > > > +-------------+ > |DRM FRAMEWORK| > +------+------+ > | > +----v----+ > | DP DRM | > +----+----+ > | > +----v----+ > +------------+| DP +----------++------+ > + | DISPLAY |+---+ | | > | +-+-----+-+ | | | > | | | | | | > | | | | | | > | | | | | | > v v v v v v > +------+ +---+ +----+ +----+ +---+ +-----+ > | DP | |DP | | DP | | DP | |DP | | DP | > |PARSER| |AUX| |LINK| |CTRL| |PHY| |POWER| > +--+---+ +---+ +----+ +--+-+ +-+-+ +-----+ > | | | > +--v---+ +v-----v+ > |DEVICE| | DP | > | TREE | |CATALOG| > +------+ +---+---+ > | > +---v----+ > |CTRL/PHY| > | HW | > +--------+ > > > These patches have dependency on clock driver changes mentioned below: > https://patchwork.kernel.org/patch/10632753/ > https://patchwork.kernel.org/patch/10632757/ > > Chandan Uddaraju (4): > dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon > drm: add constant N value in helper file > drm/msm/dp: add displayPort driver support > drm/msm/dp: add support for DP PLL driver > > Jeykumar Sankaran (1): > drm/msm/dpu: add display port support in DPU > > .../devicetree/bindings/display/msm/dp-sc7180.yaml | 325 ++++ > .../devicetree/bindings/display/msm/dpu.txt | 16 +- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > drivers/gpu/drm/msm/Kconfig | 21 + > drivers/gpu/drm/msm/Makefile | 16 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 28 +- > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 +- > drivers/gpu/drm/msm/dp/dp_aux.c | 531 ++++++ > drivers/gpu/drm/msm/dp/dp_aux.h | 35 + > drivers/gpu/drm/msm/dp/dp_catalog.c | 988 +++++++++++ > drivers/gpu/drm/msm/dp/dp_catalog.h | 86 + > drivers/gpu/drm/msm/dp/dp_ctrl.c | 1707 ++++++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_ctrl.h | 35 + > drivers/gpu/drm/msm/dp/dp_display.c | 943 +++++++++++ > drivers/gpu/drm/msm/dp/dp_display.h | 31 + > drivers/gpu/drm/msm/dp/dp_drm.c | 170 ++ > drivers/gpu/drm/msm/dp/dp_drm.h | 19 + > drivers/gpu/drm/msm/dp/dp_hpd.c | 69 + > drivers/gpu/drm/msm/dp/dp_hpd.h | 79 + > drivers/gpu/drm/msm/dp/dp_link.c | 1216 ++++++++++++++ > drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ > drivers/gpu/drm/msm/dp/dp_panel.c | 490 ++++++ > drivers/gpu/drm/msm/dp/dp_panel.h | 95 ++ > drivers/gpu/drm/msm/dp/dp_parser.c | 473 ++++++ > drivers/gpu/drm/msm/dp/dp_parser.h | 220 +++ > drivers/gpu/drm/msm/dp/dp_power.c | 545 +++++++ > drivers/gpu/drm/msm/dp/dp_power.h | 115 ++ > drivers/gpu/drm/msm/dp/dp_reg.h | 489 ++++++ > drivers/gpu/drm/msm/dp/pll/dp_pll.c | 127 ++ > drivers/gpu/drm/msm/dp/pll/dp_pll.h | 57 + > drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c | 401 +++++ > drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.h | 86 + > drivers/gpu/drm/msm/dp/pll/dp_pll_10nm_util.c | 524 ++++++ > drivers/gpu/drm/msm/msm_drv.c | 2 + > drivers/gpu/drm/msm/msm_drv.h | 53 +- > include/drm/drm_dp_helper.h | 2 + > 37 files changed, 10178 insertions(+), 23 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h > create mode 100644 drivers/gpu/drm/msm/dp/pll/dp_pll.c > create mode 100644 drivers/gpu/drm/msm/dp/pll/dp_pll.h > create mode 100644 drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c > create mode 100644 drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.h > create mode 100644 drivers/gpu/drm/msm/dp/pll/dp_pll_10nm_util.c > > -- > 1.9.1
