On Thu, Apr 23, 2020 at 7:59 AM Iskren Chernev <iskren.chernev@xxxxxxxxx> wrote: > > > On 4/20/20 11:55 PM, Rob Herring wrote: > > On Mon, Apr 13, 2020 at 07:44:39PM +0300, Iskren Chernev wrote: > >> + patternProperties: > >> + "^LDO([1-9]|1[0-5])$": > >> + type: object > >> + allOf: > >> + - $ref: regulator.yaml# > >> + > >> + "^BUCK|BUCKBOOST$": > >> + type: object > >> + allOf: > >> + - $ref: regulator.yaml# > >> + > >> + additionalProperties: false > > > > You are defining a property called 'additionalProperties'. This one > > should be dropped because additionalProperties doesn't work with a $ref. > > > > I got the idea from mps,mpq7920.yaml. It has additionalProperties in the > exact same places that I do. Also bd718(28|37|47).yaml seem to use > additionalProperties inside patternProperties. Shall I modify it as well? Indeed. mps,mp5416.yaml too. I'll fix all of these and few non-regulator ones so I can get them into rc3. > I couldn't find the core schema for this yaml: > http://devicetree.org/meta-schemas/core.yaml (gives 404). Is there a way > to verify the validity of the yaml? Running 'make dt_binding_check'. The url is just convention and while files could be there they aren't. They are all contained in the dtschema module[1]. However, in this case the meta-schema fails to check for this. It is technically valid as it is saying you can't have a DT property called 'additionalProperties'. I've written a check now which should disallow listing any DT property names which are json-schema vocabulary. Once the failures get fixed I'll add it to the meta-schema. > Also, this patch is already merged in linux-next. I guess I shall submit > a new patch with the fixes standalone? Yes, should be on top of this one. Thanks, Rob [1] https://github.com/devicetree-org/dt-schema
