Re: [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96

[Masami Hiramatsu <masami.hiramatsu@xxxxxxxxxx>]

Hello Yamada-san,

2020年4月23日(木) 0:10 Masahiro Yamada <masahiroy@xxxxxxxxxx>:
>
> Hiramatsu-san
>
> On Wed, Apr 22, 2020 at 11:50 AM Masami Hiramatsu
> <masami.hiramatsu@xxxxxxxxxx> wrote:
>
> > +
> > +&eth {
> > +       status = "okay";
> > +       phy-mode = "rgmii";
> > +       pinctrl-0 = <&pinctrl_ether_rgmii>;
>
> These two lines are actually redundant because RGMII
> is the default in uniphier-ld20.dtsi
> (and uniphier-ld20-ref.dts skips them.)
>
> Did you intentionally make it verbose?

Oops, no, we don't need it. It's a legacy code (IIRC, there's a
historical reason).


> > +&spi3 {
> > +       status = "okay";
> > +       #address-cells = <1>;
> > +       #size-cells = <0>;
>
> Adding #address-cells and #size-sizes to a board DTS
> is strange.

Indeed.

> I will apply this:
> https://lore.kernel.org/patchwork/patch/1229497/
> then delete the lines above.

OK, I'll update.

Thank you,



-- 
Masami Hiramatsu