Hi Hui, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v5.7-rc2 next-20200420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Hui-Song/gpio-mpc8xxx-Add-shutdown-function/20200410-000846 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/gpio/gpio-mpc8xxx.c:463:14: error: initialization of 'void (*)(struct platform_device *)' from incompatible pointer type 'int (*)(struct platform_device *)' [-Werror=incompatible-pointer-types] 463 | .shutdown = mpc8xxx_shutdown, | ^~~~~~~~~~~~~~~~ drivers/gpio/gpio-mpc8xxx.c:463:14: note: (near initialization for 'mpc8xxx_plat_driver.shutdown') cc1: some warnings being treated as errors vim +463 drivers/gpio/gpio-mpc8xxx.c 448 449 static int mpc8xxx_shutdown(struct platform_device *pdev) 450 { 451 struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev); 452 453 if (mpc8xxx_gc->irq) { 454 irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL); 455 irq_domain_remove(mpc8xxx_gc->irq); 456 } 457 458 return 0; 459 } 460 static struct platform_driver mpc8xxx_plat_driver = { 461 .probe = mpc8xxx_probe, 462 .remove = mpc8xxx_remove, > 463 .shutdown = mpc8xxx_shutdown, 464 .driver = { 465 .name = "gpio-mpc8xxx", 466 .of_match_table = mpc8xxx_gpio_ids, 467 }, 468 }; 469 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
