On Fri, 17 Apr 2020 21:08:22 +0200, Martin Blumenstingl wrote: > The power domains on the 32-bit Meson8/Meson8b/Meson8m2 SoCs are very > similar to what G12A still uses. The (known) differences are: > - Meson8 doesn't use any reset lines at all > - Meson8b and Meson8m2 use the same reset lines, which are different > from what the 64-bit SoCs use > - there is no "vapb" clock on the older SoCs > - amlogic,ao-sysctrl cannot point to the whole AO sysctrl region but > only the power management related registers > > Add a new compatible string and adjust clock and reset line expectations > for each SoC. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > --- > .../bindings/power/amlogic,meson-ee-pwrc.yaml | 75 ++++++++++++++----- > include/dt-bindings/power/meson8-power.h | 13 ++++ > 2 files changed, 71 insertions(+), 17 deletions(-) > create mode 100644 include/dt-bindings/power/meson8-power.h > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.example.dt.yaml: power-controller: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' See https://patchwork.ozlabs.org/patch/1272441 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
