On 4/20/20 10:59 AM, Benjamin Gaignard wrote: > Add a subnode to STM low power timer bindings to support timer driver > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > --- > .../devicetree/bindings/mfd/st,stm32-lptimer.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml > index ddf190cb800b..64bab1c3bdac 100644 > --- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml > +++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml > @@ -33,6 +33,9 @@ properties: > items: > - const: mux > > + interrupts: > + maxItems: 1 > + > "#address-cells": > const: 1 > > @@ -93,6 +96,16 @@ patternProperties: > required: > - compatible > > + timer: > + type: object > + > + properties: > + compatible: > + const: st,stm32-lptimer-timer > + > + required: > + - compatible > + > required: > - "#address-cells" > - "#size-cells" > @@ -106,11 +119,13 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/clock/stm32mp1-clks.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > timer@40002400 { > compatible = "st,stm32-lptimer"; > reg = <0x40002400 0x400>; > clocks = <&timer_clk>; > clock-names = "mux"; > + interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>; > #address-cells = <1>; > #size-cells = <0>; > > @@ -131,6 +146,10 @@ examples: > timer { > compatible = "st,stm32-lptimer-timer"; > }; > + > + timer { > + compatible = "st,stm32-lptimer-timer"; > + }; Hi Benjamin, It looks like the compatible is duplicated in this example. Also, from "PATCH v6" I don't see the wakeup-source flag in your resend. Can you double-check ? Thanks, Best Regards, Fabrice > }; > > ... >