On Fri, 17 Apr 2020 16:21:47 +0800 "Ramuthevar,Vadivel MuruganX" <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx> wrote: > + > + res = devm_platform_ioremap_resource_byname(pdev, lgm_host->cs_name); > + lgm_host->nandaddr_va = res; > + nandaddr_pa = res->start; > + if (IS_ERR(lgm_host->nandaddr_va)) > + return PTR_ERR(lgm_host->nandaddr_va); Hm, I didn't realize you needed the physical address for DMA transfers. Just use platform_get_resource_by_name()+devm_ioremap_resource() in that case. > + > + writel(LGM_BUSCON_CMULT_V4 | LGM_BUSCON_RECOVC(1) | > + LGM_BUSCON_HOLDC(1) | LGM_BUSCON_WAITRDC(2) | > + LGM_BUSCON_WAITWRC(2) | LGM_BUSCON_BCGEN_CS | LGM_BUSCON_ALEC | > + LGM_BUSCON_SETUP_EN, lgm_host->lgm_va + LGM_BUSCON(cs)); I'm sure some the timings you hardcode here can be extracted from the NAND timings. Can you see if you can implement ->setup_data_interface() instead.
