Hi Avri, > -----Original Message----- > From: Avri Altman <Avri.Altman@xxxxxxx> > Sent: 18 April 2020 18:09 > To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; robh@xxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; krzk@xxxxxxxxxx; > martin.petersen@xxxxxxxxxx; kwmad.kim@xxxxxxxxxxx; > stanley.chu@xxxxxxxxxxxx; cang@xxxxxxxxxxxxxx; linux-samsung- > soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI > > > > > > This patch-set introduces UFS (Universal Flash Storage) host > > controller support for Samsung family SoC. Mostly, it consists of UFS > > PHY and host specific driver. > > > > - Changes since v5: > > * re-introduce various quicks which was removed because of no driver > > * consumer of those quirks, initial 4 patches does the same. > You forgot to add those quirks to ufs_fixups. ufs_fixups are for ufs __device__ related quirks, what I have posted are all host controller quirks. Please have a look on the other quirks related to HCI like UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION Which is used in other vendor HCI driver. Let me know if I am missing anything here. > Each patch that introduces a quirk needs to introduce its users as well - This is > the reason it was removed in the first place. > > Thanks, > Avri
