On Saturday, May 17, 2014 01:04:29 AM Rafael J. Wysocki wrote:
> On Friday, May 16, 2014 07:54:01 PM Kukjin Kim wrote:
> > Jonghwan Choi wrote:
> > >
> > > Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to
> > > mach") which lands in samsung tree causes build breakage
> > > for cpufreq-exynos like following:
> > >
> > > drivers/cpufreq/exynos-cpufreq.c: In function 'exynos_cpufreq_probe':
> > > drivers/cpufreq/exynos-cpufreq.c:166:2: error: implicit declaration of
> > > function 'soc_is_exynos4210'
> > > [-Werror=implicit-function-declaration]
> > > drivers/cpufreq/exynos-cpufreq.c:168:2: error: implicit declaration of
> > > function 'soc_is_exynos4212'
> > > [-Werror=implicit-function-declaration]
> > > drivers/cpufreq/exynos-cpufreq.c:168:2: error: implicit declaration of
> > > function 'soc_is_exynos4412'
> > > [-Werror=implicit-function-declaration]
> > > drivers/cpufreq/exynos-cpufreq.c:170:2: error: implicit declaration of
> > > function 'soc_is_exynos5250'
> > > [-Werror=implicit-function-declaration]
> > > cc1: some warnings being treated as errors
> > > make[2]: *** [drivers/cpufreq/exynos-cpufreq.o] Error 1
> > > make[2]: *** Waiting for unfinished jobs....
> > > drivers/cpufreq/exynos4x12-cpufreq.c: In function 'exynos4x12_set_clkdiv':
> > > drivers/cpufreq/exynos4x12-cpufreq.c:118:2: error: implicit declaration of
> > > function 'soc_is_exynos4212'
> > > [-Werror=implicit-function-declaration]
> > > cc1: some warnings being treated as errors
> > > make[2]: *** [drivers/cpufreq/exynos4x12-cpufreq.o] Error 1
> > > make[1]: *** [drivers/cpufreq] Error 2
> > > This fixes above error with getting SoC information via
> > > of_machine_is_compatible() instead of soc_is_exynosXXXX().
> > >
> >
> > Probably,
> > Suggested-by: Tomasz Figa ?
> >
> > > Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> >
> > Looks better.
> >
> > Rafael, if you have no objection on this, shall I pick this into samsung
> > tree for 3.16 because of the current build breakage with enabling exynos
> > cpufreq?
>
> Please go ahead.
Actually, this conflicts with one patch already in my tree. The resoultion
is quite obvious, but it would be better to avoid this conflict altogether.
Rafael
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
