Hi Anson, thanks for the patches :) one last nitpick. On 20-04-17 08:41, Anson Huang wrote: ... > +examples: > + # Clock Control Module node: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + clks: clock-controller@20c4000 { > + compatible = "fsl,imx6q-ccm"; > + reg = <0x020c4000 0x4000>; > + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>, > + <0 88 IRQ_TYPE_LEVEL_HIGH>; The imx6ull and others start using the GIC_SPI define within the example. We should take the chance to uniform that. Apart of this feel free to add my: Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> Regards, Marco > + #clock-cells = <1>; > + };