On Thu, Apr 16, 2020 at 10:14 AM Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx> wrote: > On Thu, Apr 16, 2020 at 09:51:37AM +0200, Linus Walleij wrote: > > The gpio changes all look fine to me +/- fixes for review comments. > > I think Uwe is incorrect for his GPIO comments; the clock is only > optional on A8040. We know this because A8040 has worked fine > without PWM support without the clock, whereas for Armada 370, > the driver has hard-failed if the clock is not present. It's fine. You are running the hardware and it should work for you. I usually go by the IETF motto "rough consensus and running code". > About the only change I would make is to move the check introduced > in patch 2 into patch 3 instead, inside the MVEBU_PWM_SOC_VARIANT_A8K > case, so that deferring for the clock works (which is necessary for > the PWM driver to be useful.) OK let's go with this. Yours, Linus Walleij
