Hi Shimoda-san,
On Thu, Apr 16, 2020 at 11:56 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > From: Geert Uytterhoeven, Sent: Wednesday, April 15, 2020 11:21 PM
> > On Tue, Apr 14, 2020 at 2:26 AM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > > Convert Renesas VMSA-Compatible IOMMU bindings documentation
> > > to json-schema.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> >
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> > > + renesas,ipmmu-main:
> > > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > > + description:
> > > + Reference to the main IPMMU instance in two cells. The first cell is
> > > + a phandle to the main IPMMU and the second cell is the interrupt bit
> > > + number associated with the particular cache IPMMU device. The interrupt
> > > + bit number needs to match the main IPMMU IMSSTR register. Only used by
> > > + cache IPMMU instances.
> >
> > This property is not valid only on R-Car Gen2 and R-Mobile APE6.
>
> That sounds good. But, since ipmmu_mm on R-Car Gen3 also is not valid,
> we cannot use compatible property for detecting it.
What do you mean by "ipmmu_mm is not valid"?
> However, I realized renesas,ipmmu-main is only used by "cache IPMMU"
> and "cache IPMMU" doesn't have interrupts property. So,
> I described the following schema and then it seems success.
> --
> if:
> properties:
> interrupts: false
> then:
> required:
> - renesas,ipmmu-main
But all other nodes should have interrupts properties, right?
So they are mutually exclusive:
oneOf:
- required:
- interrupts
- required:
- renesas,ipmmu-main
> Especially, I could find missing renesas,ipmmu-main property on r8a77980.dtsi
> like below :) So, I'll make and submit a fixing r8a77980.dtsi patch later (maybe tomorrow).
Good! ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
