Re: [PATCH 2/2] dt-bindings: dma: renesas,usb-dmac: convert bindings to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shimoda-san,

On Thu, Apr 16, 2020 at 4:04 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > From: Geert Uytterhoeven, Sent: Wednesday, April 15, 2020 10:56 PM
> <snip>
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.yaml
> > > +  interrupts:
> > > +    maxItems: 2
> >
> > Is there a use case for specifying a single interrupt?
>
> No. All USB-DMAC of R-Car Gen2/3 and RZ/Gn has 2 channels.
> In case of R-Car Gen3, please refer to the Figure 75.1 USB-DMAC Block Diagram.
> These USB-DMACn have CH0 and CH1

Thanks for confirming!

> > > +  dma-channels:
> > > +    maximum: 2
> >
> > Is there a use case for specifying a single channel?
> >
> > > +
> > > +  iommus:
> > > +    maxItems: 2
> >
> > Likewise?
>
> As I mentioned above, there is not a use case for specifying a single channel.

Hence I think all of these should have "const: 2" or "minItems: 2".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux