RE: [PATCH 1/5] dt-bindings: clock: Convert i.MX6Q clock to json-schema

Anson Huang <anson.huang@xxxxxxx> · Thu, 16 Apr 2020 06:16:23 +0000



Hi, Marco

> Subject: Re: [PATCH 1/5] dt-bindings: clock: Convert i.MX6Q clock to
> json-schema
> 
> Hi Anson,
> 
> thanks for the patch. I have two questions please see inline which applies to all
> patches.
> 
> On 20-04-16 12:26, Anson Huang wrote:
> 
> ...
> 
> > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > new file mode 100644
> > index 0000000..084d4f0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fclock%2Fimx6q-clock.yaml%23&amp;data=02%7C
> 01%7
> >
> +Canson.huang%40nxp.com%7Cf07db2c34e834628725208d7e1c63083%7C6
> 86ea1d3b
> >
> +c2b4c6fa92cd99c5c301635%7C0%7C0%7C637226113645218967&amp;sdat
> a=sBVaIF
> > +hEoFSfaot7P%2Bjcbu6gnAlaB%2BDeEUqn3sv3%2BA8%3D&amp;reserved=0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=02%7C01%7Cans
> on.hua
> >
> +ng%40nxp.com%7Cf07db2c34e834628725208d7e1c63083%7C686ea1d3bc2
> b4c6fa92
> >
> +cd99c5c301635%7C0%7C0%7C637226113645218967&amp;sdata=KLIuh1sJ
> 2OQDp%2B
> > +zSncLn87ziXGb85rwJFu2NnLgvxGI%3D&amp;reserved=0
> > +
> > +title: Clock bindings for Freescale i.MX6 Quad
> > +
> > +maintainers:
> > +  - Anson Huang <Anson.Huang@xxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    const: fsl,imx6q-ccm
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    minItems: 1
> 
> Why 1 and not 2? The RM describes that the ccm has 2 interrupts.

This is a typo, since we all use 2 interrupts for ccm, I will change them to ONLY 2;

> 
> > +    maxItems: 2
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: 24m osc
> > +      - description: 32k osc
> > +      - description: ckih1 clock input
> > +      - description: anaclk1 clock input
> > +      - description: anaclk2 clock input
> > +
> > +  clock-names:
> > +    items:
> > +      - const: osc
> > +      - const: ckil
> > +      - const: ckih1
> > +      - const: anaclk1
> > +      - const: anaclk2
> > +
> > +  fsl,pmic-stby-poweroff:
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +    description: |
> > +      Use this property if the SoC should be powered off by external power
> > +      management IC (PMIC) triggered via PMIC_STBY_REQ signal.
> > +      Boards that are designed to initiate poweroff on PMIC_ON_REQ
> signal should
> > +      be using "syscon-poweroff" driver instead.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - '#clock-cells'
> > +
> > +examples:
> > +  # Clock Control Module node:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    clks: clock-controller@20c4000 {
> > +        compatible = "fsl,imx6q-ccm";
> > +        reg = <0x020c4000 0x4000>;
> > +        interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>,
> > +                     <0 88 IRQ_TYPE_LEVEL_HIGH>;
> > +        #clock-cells = <1>;
> > +    };
> > +
> > +...
> 
> Why these '...' here?

I will remove it

Thanks,
Anson

> 
> Regards,
>   Marco
> 
> > --
> > 2.7.4