On Wed, Apr 15, 2020 at 2:29 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> Hello Rob,
>
> On Wed, Apr 15, 2020 at 01:26:39PM -0500, Rob Herring wrote:
> > The example for the CrOS EC PWM is incomplete and now generates a dtc
> > warning:
> >
> > Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.example.dts:17.11-23.11:
> > Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg or ranges property
> >
> > Fixing this results in more warnings as a parent spi node is needed as
> > well.
> >
> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> > Cc: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Cc: Benson Leung <bleung@xxxxxxxxxxxx>
> > Cc: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> > Cc: Guenter Roeck <groeck@xxxxxxxxxxxx>
> > Cc: linux-pwm@xxxxxxxxxxxxxxx
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > .../bindings/pwm/google,cros-ec-pwm.yaml | 17 ++++++++++++-----
> > 1 file changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml
> > index 24c217b76580..41ece1d85315 100644
> > --- a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml
> > @@ -31,10 +31,17 @@ additionalProperties: false
> >
> > examples:
> > - |
> > - cros-ec@0 {
> > - compatible = "google,cros-ec-spi";
> > - cros_ec_pwm: ec-pwm {
> > - compatible = "google,cros-ec-pwm";
> > - #pwm-cells = <1>;
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + cros-ec@0 {
> > + compatible = "google,cros-ec-spi";
> > + reg = <0>;
> > +
> > + cros_ec_pwm: ec-pwm {
> > + compatible = "google,cros-ec-pwm";
> > + #pwm-cells = <1>;
> > + };
>
> Looks reasonable
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Thanks.
> Is this supposed to go via the pwm tree, or do you apply yourself via a
> device-tree tree?
I'll take it for rc2.
Rob
