Re: [PATCH 2/4] dt-bindings: display: bridge: Convert simple-bridge bindings to YAML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On Tue, Apr 14, 2020 at 05:00:00PM -0500, Rob Herring wrote:
> On Mon, Apr 06, 2020 at 02:23:16AM +0300, Laurent Pinchart wrote:
> > The simple-bridge driver supports multiple simple or dumb bridges,
> > covered by different compatible strings but otherwise identical DT
> > bindings. Some of those bridges have undocumented bindings, while others
> > are documented in text form in separate files. Group them all in a
> > single binding and convert it to YAML.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/display/bridge/adi,adv7123.txt   | 50 ----------
> >  .../bindings/display/bridge/dumb-vga-dac.txt  | 50 ----------
> >  .../display/bridge/simple-bridge.yaml         | 99 +++++++++++++++++++
> >  .../bindings/display/bridge/ti,ths813x.txt    | 51 ----------
> >  4 files changed, 99 insertions(+), 151 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt
> >  delete mode 100644 Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt
> > deleted file mode 100644
> > index a6b2b2b8f3d9..000000000000
> > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt
> > +++ /dev/null
> > @@ -1,50 +0,0 @@
> > -Analog Device ADV7123 Video DAC
> > --------------------------------
> > -
> > -The ADV7123 is a digital-to-analog converter that outputs VGA signals from a
> > -parallel video input.
> > -
> > -Required properties:
> > -
> > -- compatible: Should be "adi,adv7123"
> > -
> > -Optional properties:
> > -
> > -- psave-gpios: Power save control GPIO
> 
> Not documented in the new schema. Did you intend to change to 
> 'enable-gpios'?

Oops, I forgot to mention that, my bad. The psave GPIO isn't supported
by the driver, and isn't used in any upstream DT files, so I thought it
would be safe to drop it, and add support it later (possibly through the
enable GPIO) if/when needed. I'll mention it in the commit message.

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux