On Mon, Apr 13, 2020 at 11:23:03PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 13, 2020 at 10:23 AM <mani@xxxxxxxxxx> wrote:
> >
> > From: Manivannan Sadhasivam <mani@xxxxxxxxxx>
> >
> > Add devicetree OF match table support for CCS811 VOC sensor.
>
> ...
>
> > +#include <linux/of.h>
>
> Why?
>
As replied to Jonathan, will drop this and of_match_ptr.
Thanks,
Mani
> ...
>
> > +static const struct of_device_id ccs811_dt_ids[] = {
> > + { .compatible = "ams,ccs811" },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(of, ccs811_dt_ids);
>
> Since it has no ugly ifdeffery...
>
> > static struct i2c_driver ccs811_driver = {
> > .driver = {
> > .name = "ccs811",
> > + .of_match_table = of_match_ptr(ccs811_dt_ids),
>
> ...use of of_match_ptr() brings a compiler warning.
>
> Drop of_match_ptr() for good. And thus drop redundant of.h.
>
> > },
>
> --
> With Best Regards,
> Andy Shevchenko
