On Wed, 14 May 2014, Maxime Coquelin wrote: > Hi Lee, > > On 05/08/2014 10:03 AM, Lee Jones wrote: > >>>>Patch adds DT entries for clockgen A0/1/10/11/12 > >>>> > >>>>Signed-off-by: Pankaj Dev <pankaj.dev@xxxxxx> > >>>>Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxx> > >>>>--- > >>>> arch/arm/boot/dts/stih416-clks.h | 15 ++ > >>> > >>>This should live in include/dt-bindings/clk > >>> > >>include/dt-bindings/clk or include/dt-bindings/clock ? > > > >I have no idea what the difference between the two are. I guess you > >are in a better position to answer that. My point was just that the > >includes should be in the include directory, rather than being held > >locally in the 'dts' directory. > > Even if these .h files are only used by the DTS files?? > > There are some .h files for pincfg related stuff, shouldn't we do > the same in this case? I believe so. There are a few include files which are only referenced from DTS(I) files. I would be cautious about needlessly overloading arch/arm/boot/dts with files which do not need to be there. This is my personal opinion though, perhaps the DT guys have other ideas. > >>>> arch/arm/boot/dts/stih416-clock.dtsi | 477 ++++++++++++++++++++++++++++++++++ > >>>> arch/arm/boot/dts/stih416.dtsi | 10 +- > >>>> 3 files changed, 497 insertions(+), 5 deletions(-) > >>>> create mode 100644 arch/arm/boot/dts/stih416-clks.h > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
