Hi Rob, thanks for the review. On 10/04/2020 18:59, Rob Herring wrote: > On Mon, Mar 30, 2020 at 12:03:18AM +0200, Daniel Lezcano wrote: [ ... ] >> + '#cooling-cells': >> + const: 2 >> + description: | >> + Must be 2, in order to specify minimum and maximum cooling state used in >> + the cooling-maps reference. The first cell is the minimum cooling state >> + and the second cell is the maximum cooling state requested. >> + >> + duration: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: | >> + The idle duration in microsecond the device begins to cool down. >> + >> + latency: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: | >> + The exit latency constraint in microsecond for the injected >> + idle state for the device. > > Both of these should have unit suffix. And then they don't need a type > def. Do you mean I should remove the $ref: /schemas/types.yaml#/definitions/uint32 and change the name to duration_us and latency_us ? [ ... ] -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
