Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> > > > > > +       for_each_set_bit(bit, indio_dev->active_scan_mask,
> > > > > > +                        indio_dev->masklength) {  
> > > > >
> > > > > One line?
> > > > >  
> > > >
> > > > It goes beyond 80 col limit... I know I could initialize these to some local  
> > > const but...
> > >
> > > That's why question mark is there.
> > > Nonetheless, if it ~2-3 characters more, I would leave it on one line anyway.
> > >
> > > JFYI: readability has a priority over 80 limit.
> > >  
> >
> > Thanks! I would say it also depends on the maintainer (not sure)? Some are more
> > strict about checkpatch...
> > Btw, the line will have 84 if one liner...  
> 
> Let's leave it to maintainer then.
> 

I care very little either way :)  In this case I'd argue that not being annoyed
by checkpatch is worth the ever so slightly uglier 2 line option but find it
hard to get worked up about it.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux