On Fri, Apr 10, 2020 at 11:19 PM Saravanan Sekar <sravanhome@xxxxxxxxx> wrote: > > changes in v7: > - fixed probe/remove order, managed and unmanaged call mix use in adc. > - Documentation dual license, i2c node with controller address Overall looks good to me, FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> One question though in reply to patch 4. > changes in v6: > - removed includes types.h in mfd, of_device.h in adc. > - fixed review comments parentheses, err check, kstrtouint > > changes in v5: > - removed platfrom data stored in mfd and directly accessed mfd struct in child > - fixed spell check and capitalization in mfd and documentation > > changes in v4: > - fixed capitalization in mfg Kconfig and documentation > > changes in v3: > - regmap for children passed using platform data and remove mfd driver info > access directly from children > > changes in v2: > - removed EXPORT_SYMBOL of register set/get helper > - regmap bit filed used, fixed other review comments > > This patch series add support for Battery charger control driver for Monolithic > Power System's MP2629 chipset, includes MFD driver for ADC battery & input > power supply measurement and battery charger control driver. > > Thanks, > Saravanan > > Saravanan Sekar (5): > dt-bindings: mfd: add document bindings for mp2629 > mfd: mp2629: Add support for mps battery charger > iio: adc: mp2629: Add support for mp2629 ADC driver > power: supply: Add support for mps mp2629 battery charger > MAINTAINERS: Add entry for mp2629 Battery Charger driver > > .../devicetree/bindings/mfd/mps,mp2629.yaml | 60 ++ > MAINTAINERS | 5 + > drivers/iio/adc/Kconfig | 10 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/mp2629_adc.c | 208 ++++++ > drivers/mfd/Kconfig | 9 + > drivers/mfd/Makefile | 2 + > drivers/mfd/mp2629.c | 86 +++ > drivers/power/supply/Kconfig | 10 + > drivers/power/supply/Makefile | 1 + > drivers/power/supply/mp2629_charger.c | 687 ++++++++++++++++++ > include/linux/mfd/mp2629.h | 28 + > 12 files changed, 1107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > create mode 100644 drivers/iio/adc/mp2629_adc.c > create mode 100644 drivers/mfd/mp2629.c > create mode 100644 drivers/power/supply/mp2629_charger.c > create mode 100644 include/linux/mfd/mp2629.h > > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
