On Tue, Apr 07, 2020 at 07:20:38PM +0300, amirmizi6@xxxxxxxxx wrote: > From: Amir Mizinski <amirmizi6@xxxxxxxxx> > > Only tpm_tis can use memory mapped I/O, which is truly mapped into > the kernel's memory space. So using ioread16/ioread32/iowrite32 turn into a > straightforward pointer dereference. > Every other driver require more complicated operations to read more than 1 > byte at a time and will just fall back to read_bytes/write_bytes. > Therefore, move this common code out of tpm_tis_spi into tpm_tis_core, so > that it is automatically used when low-level drivers do not implement the > specialized methods. > > Co-developed-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> > Signed-off-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> > Signed-off-by: Amir Mizinski <amirmizi6@xxxxxxxxx> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> Just noticed that the short summary is still wrong. As far as I remember I asked to fix it. tpm: tpm_tis: Make implementation of read16 read32 write32 optional In English you put comma between enumerated things except for the last thing where you use and-conjuction. How hard is it seriously to write legit sentences? /Jarkko
