Re: [PATCH v2 2/2] dt-bindings: mms114: document melfas,mms345l binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stephan,

On Sun, Apr 05, 2020 at 07:09:04PM +0200, Stephan Gerhold wrote:
> The mms114 driver now supports MMS345L; document the
> melfas,mms345l binding that is used for it.
> 
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: Andi Shyti <andi@xxxxxxxxxxx>
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>

just one nitpick, the signing should be sorted in chronological
order, I see that you reverted it.

You first signed it as the author, then I reviewed it and the Rob
acked it, so that it should be:

  Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
  Reviewed-by: Andi Shyti <andi@xxxxxxxxxxx>
  Acked-by: Rob Herring <robh@xxxxxxxxxx>

you reversed it.

Other than that, I'm sorry I couldn't help you but I haven't
received answers from Samsung about getting the prototypes.
However I don't see reason for not applying the patch.

Andi



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux