On 3/30/2020 8:40 AM, Rob Herring wrote: > On Fri, 27 Mar 2020 16:47:08 -0400, Al Cooper wrote: >> Add DT bindings for Broadcom STB USB EHCI and XHCI drivers. >> >> NOTE: The OHCI driver is not included because it uses the generic >> platform driver. >> >> Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx> >> --- >> .../bindings/usb/brcm,bcm7445-ehci.yaml | 61 +++++++++++++++++++ >> .../devicetree/bindings/usb/usb-xhci.txt | 1 + >> 2 files changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@f0b00300: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+' This warning does not seem to be legitimate, the 'interrupt-names' property is a valid one, where do we update the schema such that it knows about it? > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@f0b00300: $nodename:0: 'ehci@f0b00300' does not match '^usb(@.*)?' This one is a legitimate one and should be fixed. -- Florian