Hi Prabhakar, On Tue, Apr 07, 2020 at 08:40:06AM +0100, Lad, Prabhakar wrote: > On Tue, Apr 7, 2020 at 8:17 AM Geert Uytterhoeven wrote: > > On Mon, Apr 6, 2020 at 6:43 PM Lad Prabhakar wrote: > > > Modes in the driver are based on xvclk frequency fixed to 24MHz, but where > > > as the OV5645 sensor can support the xvclk frequency ranging from 6MHz to > > > 24MHz. So instead making clock-frequency as dt-property just let the > > > driver enforce the required clock frequency. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > However, still wondering about the "xvclk" name above and in the definition > > below. Is this the naming from the datasheet? > > The DT bindings nor the driver use the "xvclk" naming. > > > xvclk naming is from the datasheet, although the 0v5645 datasheet on > publicly available I have referred [1]/[2]. > If I am not wrong all the ov sensors have the same naming convention as xvclk. > > [1] https://cdn.sparkfun.com/datasheets/Sensors/LightImaging/OV5640_datasheet.pdf > [2] https://www.ovt.com/download/sensorpdf/126/OmniVision_OV5645.pdf The clock in DT should really have been named xvclk, but it's too late to change that. We can follow one of two approaches, either naming everything xclk, and naming everything but the DT property xvclk. Both have pros and cons, feel free to pick your preferred option, but in any case a comment to explain the issue would be useful. > > > --- a/drivers/media/i2c/ov5645.c > > > +++ b/drivers/media/i2c/ov5645.c > > > @@ -61,6 +61,8 @@ > > > #define OV5645_SDE_SAT_U 0x5583 > > > #define OV5645_SDE_SAT_V 0x5584 > > > > > > +#define OV5645_XVCLK_FREQ 24000000 > > > + -- Regards, Laurent Pinchart
